-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange placeholder behaviour in input field #696
Conversation
It seems to be an env situation with the font. I see that the list of fonts goes for a bit and not sure if this is Antd configuration but we might be able to re-write it and use something more generic if Avenir is missing.
|
Adapting the font might be another solution. But as mentioned above, i've not found any other use of an apostrophe in the messages. For this reason, I vote in favour of the replacement, as this change also has much less impact on the rest of the UI. |
3d50ad4
to
02393a0
Compare
@votdev can you rebase |
Test on the latest Chrome, firefox and edge can't reproduce this issue. Looks like the browser font issue. @votdev , could you rebase with master ? then I can approve and merge. |
Replace `it’s` with `it is` because the apostrophe is rendered with a big space with the configured `AvenirNext-Regular` font-family. This is the only occurrence of `it’s` in the whole UI, everywhere else `it is` is used. Perhaps for certain reasons. Signed-off-by: Volker Theile <vtheile@suse.com>
02393a0
to
55fb7cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Replace
it’s
withit is
because the apostrophe is rendered with a big space with the configuredAvenirNext-Regular
font-family. This is the only occurrence ofit’s
in the whole UI, everywhere elseit is
is used. Perhaps for certain reasons.Which issue(s) this PR fixes:
longhorn/longhorn#7917