Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange placeholder behaviour in input field #696

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

votdev
Copy link
Contributor

@votdev votdev commented Feb 13, 2024

Replace it’s with it is because the apostrophe is rendered with a big space with the configured AvenirNext-Regular font-family. This is the only occurrence of it’s in the whole UI, everywhere else it is is used. Perhaps for certain reasons.

Which issue(s) this PR fixes:

longhorn/longhorn#7917

@votdev votdev self-assigned this Feb 13, 2024
@votdev votdev requested a review from a team as a code owner February 13, 2024 14:07
@votdev votdev added the bug label Feb 13, 2024
@scures
Copy link
Contributor

scures commented Feb 13, 2024

It seems to be an env situation with the font. I see that the list of fonts goes for a bit and not sure if this is Antd configuration but we might be able to re-write it and use something more generic if Avenir is missing.

AvenirNext-Regular, "Helvetica Neue", "lucida grande", PingFangHK-Light, STHeiti, "Heiti SC", "Hiragino Sans GB", "Microsoft JhengHei", "Microsoft Yahei", SimHei, "WenQuanYi Micro Hei", "Droid Sans", Roboto, Helvetica, Tahoma, Arial, "sans-serif"

It renders Ok on MacOS
image

@votdev
Copy link
Contributor Author

votdev commented Feb 14, 2024

It seems to be an env situation with the font. I see that the list of fonts goes for a bit and not sure if this is Antd configuration but we might be able to re-write it and use something more generic if Avenir is missing.

AvenirNext-Regular, "Helvetica Neue", "lucida grande", PingFangHK-Light, STHeiti, "Heiti SC", "Hiragino Sans GB", "Microsoft JhengHei", "Microsoft Yahei", SimHei, "WenQuanYi Micro Hei", "Droid Sans", Roboto, Helvetica, Tahoma, Arial, "sans-serif"

It renders Ok on MacOS image

Adapting the font might be another solution. But as mentioned above, i've not found any other use of an apostrophe in the messages. For this reason, I vote in favour of the replacement, as this change also has much less impact on the rest of the UI.

@scures
Copy link
Contributor

scures commented Mar 19, 2024

@votdev can you rebase master? It might fix the codespell gate.

@a110605
Copy link
Contributor

a110605 commented Jun 18, 2024

Test on the latest Chrome, firefox and edge can't reproduce this issue. Looks like the browser font issue.
But it's okay to minor replace it's to it is.

@votdev , could you rebase with master ? then I can approve and merge.

Replace `it’s` with `it is` because the apostrophe is rendered with a big space with the configured `AvenirNext-Regular` font-family. This is the only occurrence of `it’s` in the whole UI, everywhere else `it is` is used. Perhaps for certain reasons.

Signed-off-by: Volker Theile <vtheile@suse.com>
Copy link
Contributor

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit 250bb2d into longhorn:master Jul 1, 2024
4 checks passed
@votdev votdev deleted the issue_7917_placeholder branch July 1, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants